Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a different meta tag for iOS #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use a different meta tag for iOS #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a434c34
Use a different meta tag to avoid double banner.
ssunzulily Mar 8, 2016
27a47e9
Better comments. And update README.md
ssunzulily Mar 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ Based on 'jQuery Smart Banner' by Arnold Daniels <arnold@jasny.net> https://gith
<head>
<title>MyPage</title>

<meta name="apple-itunes-app" content="app-id=502838820">
<!-- Mobile Safari will automatically show a built in banner when detect meta tag apple-itunes-app.
Use a different tag to avoid show two banners. -->
<meta name="apple-itunes-app-custom" content="app-id=502838820">
<meta name="google-play-app" content="app-id=ru.hh.android">
<meta name="viewport" content="width=device-width, initial-scale=1.0">

Expand Down
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ var userLang = userLangAttribute.slice(-2) || 'us';
// platform dependent functionality
var mixins = {
ios: {
appMeta: 'apple-itunes-app',
// Mobile Safari will automatically show a built in banner when detect meta tag apple-itunes-app.
// Use a different tag to avoid show two banners.
appMeta: 'apple-itunes-app-custom',
iconRels: ['apple-touch-icon-precomposed', 'apple-touch-icon'],
getStoreLink: function() {
return 'https://itunes.apple.com/' + this.options.appStoreLanguage + '/app/id' + this.appId;
Expand Down
4 changes: 2 additions & 2 deletions smart-app-banner.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.