Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade multiple dependencies #375

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Upgrade multiple dependencies #375

merged 1 commit into from
Aug 25, 2022

Conversation

iblancasa
Copy link
Collaborator

What this PR does / why we need it:

  • Upgrade multiple dependencies (specially the Kubernetes client dependencies) to latest (20Jul2022)
  • Fix tests (unit tests, integration tests and E2E tests) to work with the new versions of the dependencies

This PR is related to #374.

Note: this PR includes the minimal changes needed to upgrade the Golang dependencies. Once this PR is merged, we can add more changes in order to remove the usage of deprecated APIs.

  • Unit tests passed
  • Integration tests passed
  • E2E tests passed
  • No vulnerabilities found

trivy analysis:

$ trivy fs .
2022-07-20T01:08:00.238+0200	INFO	Vulnerability scanning is enabled
2022-07-20T01:08:00.239+0200	INFO	Secret scanning is enabled
2022-07-20T01:08:00.239+0200	INFO	If your scanning is slow, please try '--security-checks vuln' to disable secret scanning
2022-07-20T01:08:00.239+0200	INFO	Please see also https://aquasecurity.github.io/trivy/v0.29.2/docs/secret/scanning/#recommendation for faster secret detection
2022-07-20T01:08:01.308+0200	INFO	Number of language-specific files: 1
2022-07-20T01:08:01.308+0200	INFO	Detecting gomod vulnerabilities...

go.mod (gomod)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

@iblancasa
Upgrade versions from multiple dependencies. Modify the tests accordi…
7595c26 
…ngly

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
kensipe
kensipe approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you sir! really great stuff!

pkg/test/utils/kubernetes_integration_test.go
@@ -46,7 +53,7 @@ func TestCreateOrUpdate(t *testing.T) {
},
})

_, err := CreateOrUpdate(context.TODO(), testenv.Client, SetAnnotation(depToUpdate, "test", "hi"), true)
_, err = CreateOrUpdate(context.TODO(), testenv.Client, SetAnnotation(depToUpdate, "test", "hi"), true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@kensipe kensipe merged commit 339332e into kudobuilder:main Aug 25, 2022
@erikgb erikgb mentioned this pull request Sep 8, 2022
Closed
iblancasa added a commit to iblancasa/kuttl that referenced this pull request Nov 17, 2022
@iblancasa
Upgrade versions for multiple dependencies. Modify the tests accordin…
d98ae7b 
…gly (kudobuilder#375)

Big dependency bumps are:
* k8s.io/api v0.20.2 -> v0.24.3
* github.com/docker/docker v20.10.14+incompatible -> v20.10.17+incompatible
* sigs.k8s.io/controller-tools v0.4.2-0.20210129215148-557da250b856 -> v0.9.2

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@asekretenko asekretenko Awaiting requested review from asekretenko

@kaiwalyajoshi kaiwalyajoshi Awaiting requested review from kaiwalyajoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iblancasa @kensipe