Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use t.Cleanup instead of defer #402

Merged
merged 7 commits into from
Nov 9, 2022
Merged

refactor: use t.Cleanup instead of defer #402

merged 7 commits into from
Nov 9, 2022

Conversation

eddycharly
Copy link
Contributor

What this PR does / why we need it:

This PR makes use t.Cleanup instead of defer.

eddycharly
eddycharly commented Nov 8, 2022
View reviewed changes
pkg/test/case.go Outdated Show resolved Hide resolved
eddycharly
eddycharly commented Nov 8, 2022
View reviewed changes
pkg/test/case.go Outdated Show resolved Hide resolved
eddycharly
eddycharly commented Nov 8, 2022
View reviewed changes
pkg/test/case.go Outdated Show resolved Hide resolved
kensipe
kensipe requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally like the changes... additional changes in case_integration_test.go required to make it compilable and runnable. Otherwise I think we are good to go

pkg/test/case_integration_test.go Outdated Show resolved Hide resolved
pkg/test/case_integration_test.go Outdated Show resolved Hide resolved
@chipzoller chipzoller mentioned this pull request Nov 9, 2022
Merged
@eddycharly eddycharly requested review from kensipe and removed request for kaiwalyajoshi and asekretenko November 9, 2022 12:56
eddycharly and others added 7 commits November 9, 2022 13:57
@eddycharly
refactor: use t.Cleanup instead of defer
c683747 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
improve
0aa4dc4 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
improve
b637f0d 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
improve
69df41a 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
improve
dd962dc 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly @kensipe
Update pkg/test/case_integration_test.go
bbcf82f 
Co-authored-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly @kensipe
Update pkg/test/case_integration_test.go
3387978 
Co-authored-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly mentioned this pull request Nov 9, 2022
Closed
kensipe
kensipe approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kensipe kensipe merged commit 3a44c1b into kudobuilder:main Nov 9, 2022
iblancasa pushed a commit to iblancasa/kuttl that referenced this pull request Nov 17, 2022
@eddycharly @kensipe @iblancasa
refactor: use t.Cleanup instead of defer (kudobuilder#402)
20fa580 
Using `testing.T.Cleanup` instead of `defer` where appropriate

Co-authored-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddycharly @kensipe