Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefer events v1 over v1beta1 #416

Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix: prefer events v1 over v1beta1 #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/test/case.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,10 @@ func (t *Case) CollectEvents(namespace string) {
return
}

err = t.collectEventsBeta1(cl, namespace)
err = t.collectEventsV1(cl, namespace)
if err != nil {
t.Logger.Log("Trying with events eventsv1 API...")
err = t.collectEventsV1(cl, namespace)
t.Logger.Log("Trying with events eventsv1beta1 API...")
err = t.collectEventsBeta1(cl, namespace)
if err != nil {
t.Logger.Log("Trying with events corev1 API...")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the log message be changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the log message according to the logic change.

err = t.collectEventsCoreV1(cl, namespace)
Expand Down