Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of APIServerArgs for testenv #439

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Dec 8, 2022

The latest testenv removed the use of configuration via args. Removing APIServerArgs from kuttl which removes the value of the flag --control-plane-config. The flag now reports it is not used in the logs and is planned to be removed from kuttl completely after v0.16.0.

To view output try: go run ./cmd/kubectl-kuttl test --start-control-plane=true --control-plane-config=foo pkg/test/test_data

Normally we would have a test to verify but this should shortly be removed.

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kensipe kensipe merged commit 5365c23 into main Dec 8, 2022
@kensipe kensipe deleted the ken/remove-testenv-config branch December 8, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants