Bump go, k8s deps and linter versions, and some fixes #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Also fix some of the complaints where there were few of them. Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
porridge
changed the title
vladbologa
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A pending dependency bump #595 requires a go lang version bump. That version seems incompatible with the old golangci-lint, so we bump both here.
Edit: the old k8s code generator cannot handle go 1.23 so we need to bump k8s deps in lockstep in the same PR 🙄 .
While at it, I refreshed the list of linters and enabled those which were producing no or few issues (after fixing them).
FTR,
exportlooprefis replaced withcopyloopvardue to language changes, andtypecheckseems gone altogether, but curiously the linter does not complain about unknown check.