Fix supported Ruby version to be only 3.1.x
#32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Current implementation of the scheduler cannot be used in Ruby ver
3.1.x
, because the scheduler of this gem accepts only 3 arguments (src) on#io_read
.3.0.x
,io_read
is called with 4 arguments (not documented, src)3.1.x
,io_read
is called with 3 arguments (doc, src)3.2.x
,io_read
is called with 3 arguments (doc is wrong, src) - Not added to CI testing yetWhat
spec.required_ruby_version = "~> 3.1.0"
in gemspec📝 Why this was not noticed so far.
The CI testing with Ruby 3.0 began to fail suddenly on some time between
Dec 13, 2022
andJul 4, 2023
.I will explain the reason of this.
On
Dec 13, 2022
✅CI testing was triggered. At this time, the latest ruby was
3.1.x
.3.0
was interpreted as3
, and the latest version of3.x
(=3.1.x
) was used.(ref: actions/runner#849 ruby/setup-ruby#252).
Since
#io_read
takes 3 arguments in Ruby3.1, the CI testing did not fail.On
Dec 25, 2022
Ruby 3.2 was released. At this time, the latest ruby became
3.2.x
.On
Jul 4, 2023
❌CI testing was triggered. At this time, the latest ruby was
3.2.x
.3.0
was interpreted as3
, and the latest version of3.x
(=3.2.x
), was used.Since
#io_read
takes 4 arguments in Ruby3.2, the CI testing failed.