This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
BREAKING CHANGE: Support minimum ESLint version is v7.
BREAKING CHANGE: drop ESLint v6 support
BREAKING CHANGE: Enable new rules in @typescript-eslint/recommended - @typescript-eslint/no-extra-non-null-assertion - @typescript-eslint/no-extra-semi - @typescript-eslint/no-non-null-asserted-optional-chain -⚠️ @typescript-eslint/prefer-as-const
You would see the warning while installing this config.
But |
MRTAFU
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint v7 has been released so we'd like to support ESLint v7.
https://eslint.org/blog/2020/05/eslint-v7.0.0-released
THIS PR IS A BREAKING CHANGE because this drops to support ESLint v6.
Tasks
@typescript-eslint/eslint-plugin
ESLint v7 typescript-eslint/typescript-eslint#1550@typescript-eslint/parser
ESLint v7 typescript-eslint/typescript-eslint#1550eslint-plugin-jsx-a11y
https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/683eslint-plugin-prettier
Add tests for running ESLint 7 prettier/eslint-plugin-prettier#291eslint-plugin-react
[New] support eslint v7 jsx-eslint/eslint-plugin-react#2635eslint-plugin-react-hooks
feat(eslint-plugin-react-hooks): Support ESLint 7.x facebook/react#18878