Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jpostcode::Address.zip_code is not set #15

Merged
merged 3 commits into from
May 7, 2019

Conversation

nishio-dens
Copy link
Contributor

I am using latest version of jpostcode-rb in my product.
I noticed that I could not get Address.zip_code so I fixed it.

[126] pry(main)> a = Jpostcode.find("1500022")
=> #<Jpostcode::Address:0x00007fe3d04f4c80 @city="渋谷区", @city_kana="シブヤク", @office_name=nil, @office_name_kana=nil, @prefecture="東京都", @prefecture_code=13, @prefecture_kana="トウキョウト", @street=nil, @town="恵比寿南", @town_kana="エビスミナミ", @zip_code=nil>

[127] pry(main)> a.zip_code
=> nil

@tknzk tknzk requested review from kakipo and tknzk May 7, 2019 00:45
@kakipo
Copy link
Member

kakipo commented May 7, 2019

@nishio-dens thx!

@kakipo kakipo merged commit aa935cb into kufu:master May 7, 2019
@tknzk tknzk mentioned this pull request May 7, 2019
@tknzk
Copy link
Contributor

tknzk commented May 7, 2019

released 0.1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants