Fix serial number of basic pension number sjis bytesize #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakasa51
force-pushed
the
fix-serial-number-of-basic-pension-number-sjis-bytesize
branch
from
c5c85c6
to
8defcca
Compare
AtsushiM
reviewed
Jun 24, 2019
| @@ -74,7 +74,7 @@ class DataRecord2225700 < ApplicationRecord | |||
| validates :income_updated_at, timeliness: { on_or_after: -> { Date.new(1989, 1, 8) }, type: :date }, allow_blank: true | |||
| validates :my_number, charset: { accept: [:numeric] }, sjis_bytesize: { is: 12 }, allow_nil: true | |||
| validates :area_code_of_basic_pension_number, charset: { accept: [:numeric] }, sjis_bytesize: { is: 4 }, allow_nil: true | |||
| validates :serial_number_of_basic_pension_number, charset: { accept: [:numeric] }, sjis_bytesize: { is: 8 }, allow_nil: true | |||
| validates :serial_number_of_basic_pension_number, charset: { accept: [:numeric] }, sjis_bytesize: { is: 6 }, allow_nil: true | |||
There was a problem hiding this comment.
📝
bytesizeの制限を 8-> 6。
kiricoのvalidateだから電子申請時にしか影響しない & そもそもまだ利用されていない値だった
wakasa51
deleted the
fix-serial-number-of-basic-pension-number-sjis-bytesize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
基礎年金番号の一連番号のバイトサイズは6が正解だが、8になっていたので直しました。
参考
https://www.nenkin.go.jp/denshibenri/setsumei/20180305.files/01.pdf