月額変更届のデータレコードを作成 #53
Merged
月額変更届のデータレコードを作成 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
mserizawa and
tknzk
and removed request for
a team
wata727
force-pushed
the
geppen
branch
2 times, most recently
from
b95ef50
to
95e0d3b
Compare
mserizawa
reviewed
Nov 5, 2019
| @@ -186,7 +186,7 @@ end | |||
| | 資格喪失届データレコード | Kirico::DataRecord22017041 | △ | | |||
| | 住所変更届データレコード | Kirico::DataRecord22187041 | ◯ | | |||
| | 算定基礎届データレコード | Kirico::DataRecord2225700 | ◯ | | |||
| | 月額変更届データレコード | Kirico::DataRecord22217041 | △ | | |||
| | 月額変更届データレコード | Kirico::DataRecord2221700 | ◯ | | |||
mserizawa
reviewed
Nov 5, 2019
| area_code_of_basic_pension_number: 基礎年金番号 課所符号 | ||
| serial_number_of_basic_pension_number: 基礎年金番号 一連番号 | ||
| seventy_years_and_over: 70歳以上被用者 | ||
| work_in_multiple_company: 二以上勤務 |
There was a problem hiding this comment.
これ用語として「二以上事業所勤務」だったりしませんかね・・・？
There was a problem hiding this comment.
🤔
仕様書上はこれに名前が付いてなかったので、他の算定基礎や賞与支払届の命名にあわせています。まとめて変えた方が良いですかねー
kirico/lib/kirico/config/locales/ja.yml
Line 114 in 3daec10
There was a problem hiding this comment.
なるほど〜了解しました！
一旦このプルリクでは OK です 🙆
wakasa51
reviewed
Nov 7, 2019
| attribute :retroacted_payment_at, Date | ||
| attribute :retroacted_payment, Integer | ||
| [3, 2, 1].each do |month| | ||
| attribute "before_#{month}_month_days" |
There was a problem hiding this comment.
クラスを指定していなさそうですけど、この場合はStringになりますかね？
There was a problem hiding this comment.
算定基礎の実装スタイルに合わせているのですが、未指定の場合は実際の値から推論されるようですね
一応明確に書いておきましょう
70歳以上被用者届のみ提出時には省略できる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
参照 https://www.nenkin.go.jp/denshibenri/setsumei/20180305.files/01.pdf
P169にある仕様に沿って、月額変更届のデータレコードを作成しました。