Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove max validation and add adjustment method #60

Merged
merged 1 commit into from
Dec 24, 2019
Merged

remove max validation and add adjustment method #60

merged 1 commit into from
Dec 24, 2019

Conversation

wakasa51
Copy link
Member

Max validations of payment_in_currency and payment_in_goods are not needed, because it is possible for them to be more than 9_999_999.

Therefore, I removed them and added adjustment method of them.

@wakasa51 wakasa51 requested a review from a team as a code owner December 24, 2019 07:05
@ghost ghost requested review from mserizawa and tknzk and removed request for a team December 24, 2019 07:06
tknzk
tknzk approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@tknzk tknzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mserizawa
mserizawa approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@mserizawa mserizawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wakasa51
Copy link
Member Author

Thanks!!

@wakasa51 wakasa51 merged commit 191327a into kufu:master Dec 24, 2019
@wakasa51 wakasa51 deleted the fix-validation-of-bonus-payment branch December 24, 2019 08:42
@wakasa51 wakasa51 mentioned this pull request Dec 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mserizawa mserizawa mserizawa approved these changes

@tknzk tknzk tknzk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wakasa51 @tknzk @mserizawa