Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NotImplementedError to expect implementation #85

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Use NotImplementedError to expect implementation #85

merged 1 commit into from
Feb 25, 2022

Conversation

meganemura
Copy link
Member

No description provided.

@meganemura meganemura requested a review from a team as a code owner February 25, 2022 08:48
@meganemura meganemura requested review from f440 and kouryou and removed request for a team February 25, 2022 08:48
f440
f440 approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@f440 f440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meganemura meganemura merged commit 9562706 into master Feb 25, 2022
@meganemura meganemura deleted the not-implemented-error branch February 25, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f440 f440 f440 approved these changes

@kouryou kouryou Awaiting requested review from kouryou kouryou is a code owner automatically assigned from kufu/group-dev-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meganemura @f440