Add user signup with GitHub OAuth #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinoppyd
force-pushed
the
features/signup
branch
from
520e2d7 to
ab0d1b2
Compare
kinoppyd
force-pushed
the
features/signup
branch
from
ab0d1b2 to
42a814c
Compare
e-ikuta
reviewed
Apr 4, 2024
app/models/profile.rb
Outdated
Comment on lines
8
to
9
| validates :name, presence: true | ||
| validates :email, presence: true |
There was a problem hiding this comment.
emailとnameはGithub側で空欄で登録できるので、必須にしないほうが親切かも？と思いました！
There was a problem hiding this comment.
emailは以下をチェックしていてもnilになるみたいです！
There was a problem hiding this comment.
必須にする場合は、profile作成失敗時に適切にエラーメッセージを表示してあげると良さそうです！
There was a problem hiding this comment.
ちなみにアバター画像については、頑張って外そうと試みたのですが、gravatarの画像が勝手に設定されちゃってできませんでした...
docによると
アカウントにサインアップすると、GitHub はとりあえずランダムなアイデンティコンを生成します。
とあるので空になることはないのかもしれません。
There was a problem hiding this comment.
emailはもしかしたら、と思っていたんですがnameは想定外だったので、チェックしていただいて助かりました。
ちょっと修正を入れます
e-ikuta
approved these changes
Apr 4, 2024
kinoppyd
force-pushed
the
features/signup
branch
from
b3422ca to
0ffb99b
Compare
|
コメントの対応として、以下の対応を入れました
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub の OAuth を使用して、サインアップする機能の実装です。