Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

スケジュールを2024年版にする #134

Merged
merged 3 commits into from
Apr 10, 2024
Merged

スケジュールを2024年版にする #134

merged 3 commits into from
Apr 10, 2024

Conversation

e-ikuta
Copy link
Collaborator

@e-ikuta e-ikuta commented Apr 9, 2024

No description provided.

db/seeds.rb Outdated
end_at: end_at
)
end
track = Track.find_or_create_by!(event: base_event, name: "TrackLarge Hall")
Copy link
Collaborator Author

@e-ikuta e-ikuta Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTのtrackは公式のページに合わせました。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTにはトラック情報がない、確認しました

@e-ikuta e-ikuta requested a review from kinoppyd April 9, 2024 07:27
Copy link
Member

@kinoppyd kinoppyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

内容的にはOKですが、できればこのタイミングでトラック名の接頭辞になってる「Track」取っちゃいたいです。
もともとは最初の2021年にAとかBの文字列しか入っていなかったので「Track」とこちら側で追加処理を行っていたのですが、ちゃんとしたトラック名が設定されるようになったのでもう必要なさそうです。

db/seeds.rb Outdated
end_at: end_at
)
end
track = Track.find_or_create_by!(event: base_event, name: "TrackLarge Hall")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTにはトラック情報がない、確認しました

@e-ikuta
Copy link
Collaborator Author

e-ikuta commented Apr 10, 2024

@kinoppyd

もともとは最初の2021年にAとかBの文字列しか入っていなかったので「Track」とこちら側で追加処理を行っていた

なるほど!そうだったんですね!なんでだろ、と思ってたんですが謎が解けました!
以下で削除しました〜!
0a4d1f0

@e-ikuta e-ikuta requested a review from kinoppyd April 10, 2024 02:24
Copy link
Member

@kinoppyd kinoppyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-ikuta e-ikuta merged commit f6678e8 into 2024 Apr 10, 2024
2 checks passed
@e-ikuta e-ikuta linked an issue Apr 10, 2024 that may be closed by this pull request
@kinoppyd kinoppyd deleted the feature/update_seed branch May 20, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

スケジュールのデータを最新版にする
2 participants