スケジュール画面のモバイル対応 #165
Merged
スケジュール画面のモバイル対応 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamakeeeeeeeeen
commented
Apr 25, 2024
| </div> | ||
| </th> | ||
| <% track_list.each do |track| %> | ||
| <% if row.tracks[track] %> |
There was a problem hiding this comment.
row.tracks[track]がない場合にpaddingを持ったdivが作られてしまうので修正しました
There was a problem hiding this comment.
これ意図的な挙動で、例えばPCで横表示するときにA, B, Cのトラックがアリ、AとCだけスケジュールが設定されていたときに表示が崩れる気がします。
There was a problem hiding this comment.
なるほど、PCに影響が出ないようにモバイルの時に不要なスペースが出ないよう考えてみます！
There was a problem hiding this comment.
@kinoppyd こちらで対応しました！
fix: トラックが歯抜けの場合でもPCではUIが崩れないようにする
kinoppyd
reviewed
Apr 25, 2024
|
確認します！ |
|
1はシュッと分からなそうなので2の対応から |
|
@kinoppyd 2の方は対応しました！ 段落ちした時は「詳細を表示」が上に来るようにしています
|
kinoppyd
reviewed
Apr 25, 2024
e-ikuta
reviewed
Apr 25, 2024
|
@e-ikuta 確認azms!!
これ対応したいですね、別途対応しましょう！ |
kinoppyd
reviewed
Apr 25, 2024
kinoppyd
approved these changes
Apr 25, 2024
e-ikuta
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一旦スケジュール画面のセッション一覧のモバイル対応をしてみました
このUIで良さそうだったらチーム画面の対応もするので触ってみてください！