Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

トップ画面を諸々アップデート #190

Merged
merged 8 commits into from
May 14, 2024
Merged

トップ画面を諸々アップデート #190

merged 8 commits into from
May 14, 2024

Conversation

e-ikuta
Copy link
Collaborator

@e-ikuta e-ikuta commented May 13, 2024 •
edited
Loading

変更内容

  • イントロの文面内の「初」をトル
  • Twitter の表記を X に変更
  • リンクをリンクっぽい見た目にする
  • リンクが別タブで開くようにする
  • 注釈を注釈っぽくする
スクリーンショット 2024-05-13 20 42 10

@e-ikuta e-ikuta requested a review from kinoppyd May 13, 2024 11:32
kinoppyd
kinoppyd approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@kinoppyd kinoppyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestを取り込んでくれればApprove

app/views/static/top.html.erb Outdated Show resolved Hide resolved
app/views/static/top.html.erb Outdated Show resolved Hide resolved
app/views/static/top.html.erb Outdated Show resolved Hide resolved
@kinoppyd
Copy link
Member

明日がDay1なので、Suggestionをセルフマージしてリリースします

@kinoppyd kinoppyd merged commit 35a8c73 into main May 14, 2024
2 checks passed
@kinoppyd kinoppyd deleted the feature/udpate_top_page branch May 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinoppyd kinoppyd kinoppyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-ikuta @kinoppyd