Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_multilingual.mdx #1466

Merged
merged 17 commits into from
Dec 26, 2024
Merged

add_multilingual.mdx #1466

merged 17 commits into from
Dec 26, 2024

Conversation

Han-Smarthr
Copy link
Contributor

@Han-Smarthr Han-Smarthr commented Dec 24, 2024

多言語化対応のガイドラインのファイルをアップロード

課題・背景

  • 多言語化対応の翻訳に関する情報発信が少なく、SalesやCSで翻訳の品質に関する課題を持っていた
  • デザインシステムで多言語化対応の翻訳について情報を発信することで社内では翻訳の品質に自信持って顧客対応ができ、ユーザーにとっても安心できる状態を目指す

やったこと

  • 多言語化対応の翻訳に関するポリシーやプロセスをMdxファイルで作成し、rc/contents/articles/accessiblility/ でアップロードした

やらなかったこと

動作確認

Previewで見てください
https://deploy-preview-1466--smarthr-design-system.netlify.app/accessibility/multilingual/

キャプチャ

Before After

多言語化対応のガイドラインのファイルをアップロード
Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit 3545f4e
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/676d0c1b28646c0008b90bda
😎 Deploy Preview https://deploy-preview-1466--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Han-Smarthr Han-Smarthr marked this pull request as draft December 24, 2024 10:14
@Han-Smarthr Han-Smarthr marked this pull request as ready for review December 25, 2024 08:19
@Han-Smarthr Han-Smarthr marked this pull request as draft December 25, 2024 08:32
@Han-Smarthr Han-Smarthr marked this pull request as ready for review December 25, 2024 08:32
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
Han-Smarthr and others added 10 commits December 26, 2024 13:44
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Copy link
Contributor

@drivesketch drivesketch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あと2箇所ありました
これも消しちゃった良いと思います
ほかは良さそうです!

src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
Han-Smarthr and others added 2 commits December 26, 2024 16:28
Co-authored-by: so <webberzeng@gmail.com>
Co-authored-by: so <webberzeng@gmail.com>
Copy link
Contributor

@drivesketch drivesketch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

何度もごめんなさい
もう一箇所表現でひっかかってるところがありました
ここだけ直したらOKだと思います
Approveするので、直してからmergeしてください〜

src/content/articles/accessibility/multilingual.mdx Outdated Show resolved Hide resolved
Co-authored-by: so <webberzeng@gmail.com>
@Han-Smarthr Han-Smarthr merged commit 25b2e1c into kufu:main Dec 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants