[SD-896]削除前のクッションとしてDropdownMenuButtonの利用を推奨する一文を削除 #1474
Merged
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for smarthr-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oremega
changed the title
oremega
requested review from
oti,
ouji-miyahara,
MasafumiKabe,
tosiiu,
fujitha,
drivesketch and
versionfive
and removed request for
ouji-miyahara
tosiiu
reviewed
Dec 26, 2024
|
@tosiiu あああー、そうですね。1つのときだからどんな操作も視覚的優先度の理由では使えないですね。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題・背景
https://smarthr.atlassian.net/browse/SD-896
削除ボタンをDropdownMenuButtonの中にいれることを推奨する必要はないので、その記述を変更したい。
やったこと
やらなかったこと
動作確認
以下よりご確認ください
https://deploy-preview-1474--smarthr-design-system.netlify.app/products/components/dropdown/dropdown-menu-button/#h3-0
キャプチャ