Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

権限編集ダイアログ内のRadioButtonPanelの個数制限を削除 #1479

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

MasafumiKabe
Copy link
Member

@MasafumiKabe MasafumiKabe commented Dec 27, 2024

課題・背景

権限設定のページにて、「操作の権限が2つ以内の場合はRadioButtonPanelを使ってください」という表記があるが、2つ以内に限定する必要はないため、その記載を削除したい。

cf. 2つ以内の表記が妥当かの相談スレ

やったこと

  • 削除した

やらなかったこと

  • 🍐

動作確認

https://deploy-preview-1479--smarthr-design-system.netlify.app/products/design-patterns/permissions-settings/#h4-5

キャプチャ

Before After

@MasafumiKabe MasafumiKabe requested a review from a team as a code owner December 27, 2024 05:56
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit b5229ab
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/676e41931ca1b0000822a933
😎 Deploy Preview https://deploy-preview-1479--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@oremega oremega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
議論の経緯も追いました。gogoです。

@MasafumiKabe MasafumiKabe merged commit a5ffd7e into main Dec 27, 2024
5 checks passed
@MasafumiKabe MasafumiKabe deleted the permissions-settings-radiobutton-panel branch December 27, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants