Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove @storybook/addon-styling as it has been deprecated #5131

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

f440
Copy link
Member

@f440 f440 commented Nov 22, 2024

関連URL

概要

Storybook起動時、以下のようなメッセージが表示されます。

WARN The following packages are incompatible with Storybook 8.4.4 as they depend on different major versions of Storybook pa
ckages:
WARN - @storybook/addon-styling@1.3.7
WARN
WARN
WARN Please consider updating your packages or contacting the maintainers for compatibility details.
WARN For more on Storybook 8 compatibility, see the linked GitHub issue:
WARN storybookjs/storybook#26031

以前対応した内容(#4522)なのですが、他の修正のタイミング(#4516)で再度パッケージが入ったようです。

改めてパッケージを削除しました。

変更内容

  • 不要なパッケージの削除
    • pnpm --filter smarthr-ui remove @storybook/addon-styling

確認方法

  • Storybookの起動(pnpm --filter smarthr-ui dev)やビルド(pnpm --filter smarthr-ui build) ができること

    pnpm --filter smarthr-ui remove @storybook/addon-styling
Copy link

pkg-pr-new bot commented Nov 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@5131

commit: 3c7c929

@f440 f440 marked this pull request as ready for review November 22, 2024 02:19
@f440 f440 requested a review from a team as a code owner November 22, 2024 02:19
@f440 f440 requested review from oti and uknmr and removed request for a team November 22, 2024 02:19
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@uknmr uknmr merged commit f936325 into master Nov 22, 2024
12 checks passed
@uknmr uknmr deleted the remove-storybook_addon-styling branch November 22, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants