feat(SideNav): Composition できるように修正 #5157
Open
+322
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
uknmr
requested changes
Dec 2, 2024
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/VRTSideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/VRTSideNav.stories.tsx
Outdated
Show resolved
Hide resolved
|
@uknmr |
uknmr
reviewed
Dec 6, 2024
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
packages/smarthr-ui/src/components/SideNav/stories/SideNav.stories.tsx
Outdated
Show resolved
Hide resolved
| parameters: { | ||
| chromatic: { disableSnapshot: true }, | ||
| }, | ||
| tags: ['skip-test-runner'], |
There was a problem hiding this comment.
<ul>をrenderに追加して対応
There was a problem hiding this comment.
<ul> 追加したのであれば、削っても大丈夫?
Suggested change
| tags: ['skip-test-runner'], |
packages/smarthr-ui/src/components/SideNav/stories/VRTSideNav.stories.tsx
Outdated
Show resolved
Hide resolved
uknmr
reviewed
Jan 7, 2025
Comment on lines
+32
to
+33
| transform: (code: string) => | ||
| code.replace(/<ul>|<\/ul>|<Stack as="ul">|<\/Stack>/g, '').trim(), |
There was a problem hiding this comment.
なるほどなぁ、と思ったんですがやるなら方針決めて全 Story ガッと対応した方が良いと思いました!
インデントが揃ってないのも気になります。
| <SideNavItemButton {...args}>サイドナビ</SideNavItemButton> | ||
| </ul> | ||
| ), | ||
| argTypes: { |
There was a problem hiding this comment.
children を control: 'text' で足したい
| child as React.ReactElement<ComponentProps<typeof SideNavItemButton>>, | ||
| { | ||
| size, | ||
| ...(childProps.onClick ? {} : { onClick }), |
There was a problem hiding this comment.
パッと見、消してしまいそうなのでコメントを残しとくとよさそう
| const sideNavItem = tv({ | ||
| slots: { | ||
| wrapper: ['smarthr-ui-SideNav-item'], | ||
| wrapper: ['smarthr-ui-SideNav-item', 'shr-list-none'], |
There was a problem hiding this comment.
SideNav 側で指定されてるので不要そう（Story のためであれば Story に書くのがよさそう）
| parameters: { | ||
| chromatic: { disableSnapshot: true }, | ||
| }, | ||
| tags: ['skip-test-runner'], |
There was a problem hiding this comment.
<ul> 追加したのであれば、削っても大丈夫?
Suggested change
| tags: ['skip-test-runner'], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1143
概要
SideNavのstoryの見直しをしました。
変更内容
確認方法
Chromaticで確認