Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(smarthr-ui-preset): narrow breakpointを追加 #5306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(smarthr-ui-preset): narrow breakpointを追加 #5306

wants to merge 1 commit into from

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Jan 20, 2025 •
edited
Loading

関連URL

#4965

概要

screensにnarrowを定義し、 narrow:shr-hoge でモバイル対応できるようにした

変更内容

  • screensにnarrowを定義
    • defaultBreakpoint.SPで定義

確認方法

てきとうに narrow:shr-bg-[red] などを当てて、横幅を狭めてみる

@Qs-F Qs-F marked this pull request as ready for review January 20, 2025 09:33
@Qs-F Qs-F requested a review from a team as a code owner January 20, 2025 09:33
@Qs-F Qs-F requested review from moshisora and s-sasaki-0529 and removed request for a team January 20, 2025 09:33
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 20, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5306

commit: 8984810

@Qs-F Qs-F requested a review from uknmr January 20, 2025 09:34
@Qs-F
Copy link
Contributor Author

Qs-F commented Jan 20, 2025 •
edited
Loading

お…？もしかしてAppHeader内でnarrow 使われてる…？

@Qs-F
Copy link
Contributor Author

Qs-F commented Jan 20, 2025

useMediaQueryによる出し分けが機能しなくなる…？どいういうことだ…？

s-sasaki-0529
s-sasaki-0529 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@s-sasaki-0529 s-sasaki-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍️ あー良いですねぇ。プロダクト側で px 決め打ちで判定しちゃってるんどえ、そのへんを統一できるようになるとハッピーそうです！

@s-sasaki-0529 s-sasaki-0529 self-requested a review January 30, 2025 00:06
@s-sasaki-0529
Copy link
Contributor

s-sasaki-0529 commented Jan 30, 2025 •
edited
Loading

あら、コード変更内容だけ見た限り流石に影響ないやろって Approve しましたが Chromatic 見る限りダメそうですね…。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshisora moshisora Awaiting requested review from moshisora moshisora is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@uknmr uknmr Awaiting requested review from uknmr

@s-sasaki-0529 s-sasaki-0529 Awaiting requested review from s-sasaki-0529

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qs-F @s-sasaki-0529