chore: CheckBoxの内部処理を最適化する #5340
Open
+50
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-CheckBox
branch
from
95b4662 to
d9400a9
Compare
commit: |
AtsushiM
commented
Jan 28, 2025
| @@ -59,48 +57,29 @@ const checkbox = tv({ | |||
| 'shr-relative shr-box-border shr-inline-block shr-h-[theme(fontSize.base)] shr-w-[theme(fontSize.base)] shr-shrink-0 shr-translate-y-[0.125em] shr-leading-none', | |||
| label: [ | |||
| 'smarthr-ui-CheckBox-label shr-ms-0.5 shr-cursor-pointer shr-text-base shr-leading-tight', | |||
| '[[data-disabled=true]>&]:shr-pointer-events-none [[data-disabled=true]>&]:shr-cursor-not-allowed [[data-disabled=true]>&]:shr-text-disabled', | |||
There was a problem hiding this comment.
動的にclassを変更するのではなく、親要素の data-disabled を確認、それに応じてstyleを変更するようにしました。
これにより、memo化の効率が良くなります
There was a problem hiding this comment.
Q: data-disabled より has-[input:disabled] のほうがsmarthr-ui内ではよく使われているかなと思ったんですが、data属性の方を選んだ理由ってありますか？
There was a problem hiding this comment.
AtsushiM
commented
Jan 28, 2025
Comment on lines
+123
to
+142
| const AriaHiddenBox = React.memo<{ className: string }>(({ className }) => ( | ||
| <span className={className} aria-hidden="true" /> | ||
| )) | ||
|
|
||
| const CheckIconArea = React.memo<Pick<Props, 'mixed'> & { className: string; iconStyle: string }>( | ||
| ({ mixed, className, iconStyle }) => ( | ||
| <span className={className}> | ||
| {mixed ? <FaMinusIcon className={iconStyle} /> : <FaCheckIcon className={iconStyle} />} | ||
| </span> | ||
| ), | ||
| ) | ||
|
|
||
| const LabeledChildren = React.memo<PropsWithChildren<{ className: string; htmlFor: string }>>( | ||
| ({ children, htmlFor, className }) => | ||
| children && ( | ||
| <label htmlFor={htmlFor} className={className}> | ||
| {children} | ||
| </label> | ||
| ), | ||
| ) |
There was a problem hiding this comment.
これらの箇所はほぼ書き換わる可能性がないため、memo化しています。
LabeledChildrenはこのコンポーネント自体のchildrenを受け取っていますが、CheckBoxの特性上、ReactNodeでわたってくる可能性はひくく、ほとんどがstringとなるため、効率は良いはずです
AtsushiM
requested review from
moshisora and
uknmr
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法