Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Dialogのscroll部分をStackではなくSection、かつ必要なflex系styleのみ設定することで余計な処理をskipする #5371

Merged
merged 1 commit into from
Feb 7, 2025
Merged

chore: Dialogのscroll部分をStackではなくSection、かつ必要なflex系styleのみ設定することで余計な処理をskipする #5371

merged 1 commit into from
Feb 7, 2025
+9 −9

Conversation

AtsushiM
Copy link
Member

@AtsushiM AtsushiM commented Feb 7, 2025

関連URL

概要

  • DialogのScroll部分の処理がStackで設定されるflex系のclassNameに依存している記述になっている
  • 依存関係が分かりづらく、かつ一見Stackが不要に見える記述になってしまうこと、Stack内のロジックの大半が本質的に不要であることから、必要なflex系のclassNameをDialog側で設定することでバグらせづらいコードにしたい

変更内容

  • DialogContentInner系からスクロール部分のStackの使用をやめ、shr-flex shr-flex-col だけ指定するように修正

確認方法

  • ActionDialog, FormDialogで画面縦幅が短い場合でも問題なくbodyがscrollできることを確認する

@AtsushiM AtsushiM marked this pull request as ready for review February 7, 2025 02:10
@AtsushiM AtsushiM requested a review from a team as a code owner February 7, 2025 02:10
@AtsushiM AtsushiM requested review from moshisora and uknmr and removed request for a team February 7, 2025 02:10
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5371

commit: cdb1b63

Qs-F
Qs-F approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Qs-F Qs-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:yosasou:

@AtsushiM AtsushiM merged commit d9a89ce into master Feb 7, 2025
13 checks passed
@AtsushiM AtsushiM deleted the chore-format-Dialog-Scroller branch February 7, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qs-F Qs-F Qs-F approved these changes

@moshisora moshisora Awaiting requested review from moshisora moshisora is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@uknmr uknmr Awaiting requested review from uknmr uknmr is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtsushiM @Qs-F