fix!: ResponseMessageをResponseStatusに名称変更 #5399
Open
+57
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qs-F
requested review from
AtsushiM and
s-sasaki-0529
and removed request for
a team
commit: |
AtsushiM
reviewed
Feb 20, 2025
packages/smarthr-ui/src/index.ts
Outdated
| @@ -102,6 +102,7 @@ export { Center, Cluster, Reel, Stack, Sidebar } from './components/Layout' | |||
| // hooks | |||
| export { useTheme } from './hooks/useTheme' | |||
| export { useDevice, DeviceProvider } from './hooks/useDevice' | |||
| export type { ResponseMessageType } from './hooks/useResponseMessage' | |||
There was a problem hiding this comment.
📝
smarthr-ui/typesからexportするResponseMessageTypeではコンポーネントとして提供しているResponsetMessageの型かも？と混乱してしまうため、ResponseMessageAttributeなど属性の型であることがわかる名称に変更する
There was a problem hiding this comment.
一旦名称決まるまでDraftにしておきます！
|
あ〜 exportsフィールドを追加するとlibとかからimportしてたやつが使えないのか… そりゃそうだ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://kufuinc.slack.com/archives/CGC58MW01/p1739929345355399
概要
ResponseMessageTypeをルートからexportするようにした
変更内容
確認方法