Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Update heroku deploy config for sending mode #238

Merged
merged 1 commit into from
Aug 9, 2024
Merged

🔧 Update heroku deploy config for sending mode #238

merged 1 commit into from
Aug 9, 2024

Conversation

yamashush
Copy link
Contributor

@yamashush yamashush commented Aug 9, 2024 •
edited
Loading

下記のPRに対する関連対応です。

新しく環境変数を追加したかと思いますので、herokuに対してボタンをポチポチで初回デプロイをする際に必要となる設定を追加しました。

ref: https://devcenter.heroku.com/articles/app-json-schema

@yamashush yamashush requested a review from a team as a code owner August 9, 2024 06:22
@yamashush yamashush requested a review from shigerix August 9, 2024 06:22
shigerix
shigerix approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@shigerix shigerix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応が漏れてましたね🙏
修正対応いただきありがとうございます！

@shigerix shigerix merged commit f84203b into kufu:main Aug 9, 2024
2 checks passed
@yamashush
Copy link
Contributor Author

いやいや、初回デプロイ以外で影響がないところなので、かなり軽微な内容ですよん。
レビュー＆マージAZMS！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shigerix shigerix shigerix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamashush @shigerix