Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importable small test dataset with FCs #227

Open
kkappler opened this issue Jul 24, 2024 · 0 comments
Open

Importable small test dataset with FCs #227

kkappler opened this issue Jul 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kkappler
Copy link
Collaborator

Context:

There are several tests that are accumulating in mth5/tests/version_1/test_fcs.py because that module also has
a function called create_mth5_with_some_test_data which makes an mth5 with some test data in the FC layer.

It would be nice if this dataset might be accessed by other test modules.

Question: How to do this?

  • formalize the test dataset by giving it a path in the mth5/data folder. Then it can be imported
    • But if we want to build the FC layer of the test dataset on the fly, we may run into problems with tests on read-only installations.
  • Maybe pytest.fixtures has a clever workaround for this?
  • The alternative of duplicating the code that builds the test dataset in other modules doesn't seem like a good workaround.
@kkappler kkappler added the enhancement New feature or request label Jul 24, 2024
kkappler added a commit that referenced this issue Jul 24, 2024
@kkappler
Add some more multivariate functionality
87f9d16 
- a sort of continuation of issue #209, but a new fork from patches as that branch is already merged
- add MultivariateLabelScheme() class to manage how we label multivariate channels
- add MultivariateDataset() class to wrap the MV xarray
- add some tests
- tests could be better organized if address issue #227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkappler