-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some changes to synthetic data examples and creation #283
Conversation
These are aimed at making synthetic data more general and easier to work with. - add some doc - stop defaulting sample_rate to 1.0Hz (explicit every time) - remove channel_nomenclature keyword from the SyntheticRun (it should only need channel names) - add (temporarily) the SyntheticRun channel-map hanlders to SynteticStation (prbobaly will be removed) - get/set channel_map - add channels_recorded to SyntheticStation metadata - explicitly pass channel names list (not Nomenclature object) to SyntheticRun - add error message to create_run_ts_from_synthetic_run to catch incorrect channel names
This PR is because tests are not passing, and I would like to separate work without passing tests from the currently passing |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## features #283 +/- ##
============================================
+ Coverage 62.47% 63.56% +1.08%
============================================
Files 167 175 +8
Lines 17606 18506 +900
============================================
+ Hits 11000 11764 +764
- Misses 6606 6742 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- use s-weigand/setup-conda@v1.0.7 - this change allows 3.9, 3.10, 3.11 to pass - 3.8 does not pass so removed it for now - tried adding 3.12 but no joy. - ModuleNotFoundError: No module named 'attr' - usr/share/miniconda/envs/mth5-test/lib/python3.12/site-packages/pytest_subtests.py
Issue #282 remains unresolved, but I added a temporary workaround so that development of |
These are aimed at making synthetic data more general and easier to work with.