Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to synthetic data examples and creation #283

Merged
merged 18 commits into from
Feb 17, 2025

Conversation

kkappler
Copy link
Collaborator

These are aimed at making synthetic data more general and easier to work with.

  • add some doc
  • stop defaulting sample_rate to 1.0Hz (explicit every time)
  • remove channel_nomenclature keyword from the SyntheticRun (it should only need channel names)
  • add (temporarily) the SyntheticRun channel-map hanlders to SynteticStation (prbobaly will be removed)
  • get/set channel_map
  • add channels_recorded to SyntheticStation metadata
  • explicitly pass channel names list (not Nomenclature object) to SyntheticRun
  • add error message to create_run_ts_from_synthetic_run to catch incorrect channel names

These are aimed at making synthetic data more general and easier to work
with.

- add some doc
- stop defaulting sample_rate to 1.0Hz (explicit every time)
- remove channel_nomenclature keyword from the SyntheticRun (it should only need channel names)
- add (temporarily) the SyntheticRun channel-map hanlders to SynteticStation (prbobaly will be removed)
 - get/set channel_map
- add channels_recorded to SyntheticStation metadata
- explicitly pass channel names list (not Nomenclature object) to SyntheticRun
- add error message to create_run_ts_from_synthetic_run to catch incorrect channel names
@kkappler
Copy link
Collaborator Author

This PR is because tests are not passing, and I would like to separate work without passing tests from the currently passing features branch (see issue #282)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.56%. Comparing base (2c131cc) to head (aa6a921).
Report is 76 commits behind head on features.

Files with missing lines Patch % Lines
mth5/data/make_mth5_from_asc.py 60.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           features     #283      +/-   ##
============================================
+ Coverage     62.47%   63.56%   +1.08%     
============================================
  Files           167      175       +8     
  Lines         17606    18506     +900     
============================================
+ Hits          11000    11764     +764     
- Misses         6606     6742     +136     
Flag Coverage Δ
tests 63.56% <84.21%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- use s-weigand/setup-conda@v1.0.7
- this change allows 3.9, 3.10, 3.11 to pass
- 3.8 does not pass so removed it for now
- tried adding 3.12 but no joy.
  - ModuleNotFoundError: No module named 'attr'
  - usr/share/miniconda/envs/mth5-test/lib/python3.12/site-packages/pytest_subtests.py
@kkappler kkappler merged commit 5e5243b into features Feb 17, 2025
6 checks passed
@kkappler kkappler deleted the synthetic_updates branch February 17, 2025 20:31
@kkappler
Copy link
Collaborator Author

Issue #282 remains unresolved, but I added a temporary workaround so that development of features can continue with testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants