fix: don't create empty ByIds queries when loading virtuals @ service…

…-cluster
kukeiko · Dec 28, 2017 · eea8edf · eea8edf
1 parent f0eddda
commit eea8edf
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/src/execution/service-cluster.ts b/src/execution/service-cluster.ts
@@ -298,11 +298,13 @@ export class ServiceCluster {
                             keys.add(e[keyName]);
                         });
 
-                        promises.push(this._loadIntoWorkspace(Query.ByIds({
-                            ids: Array.from(keys),
-                            entity: nav.otherType,
-                            expand: v.extracted.expansions
-                        })));
+                        if (keys.size > 0) {
+                            promises.push(this._loadIntoWorkspace(Query.ByIds({
+                                ids: Array.from(keys),
+                                entity: nav.otherType,
+                                expand: v.extracted.expansions
+                            })));
+                        }
                         break;
 
                     case "array:child":
@@ -331,11 +333,13 @@ export class ServiceCluster {
                             keys.forEach(k => refKeys.add(k));
                         });
 
-                        promises.push(this._loadIntoWorkspace(Query.ByIds({
-                            ids: Array.from(keys),
-                            entity: nav.otherType,
-                            expand: v.extracted.expansions
-                        })));
+                        if (keys.size > 0) {
+                            promises.push(this._loadIntoWorkspace(Query.ByIds({
+                                ids: Array.from(keys),
+                                entity: nav.otherType,
+                                expand: v.extracted.expansions
+                            })));
+                        }
                         break;
                 }
             });