Makefile: add install target #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix build error:
```
gcc -g -Wall -std=c99 -Wwrite-strings -funroll-loops -Wstrict-prototypes -I. -Iinclude -fPIC -Ofast -DSVD_ACTIVATED=1 -DCTRLC=1 -DCOPYAMATRIX=1 -DLAPACK_LIB_FOUND -DUSE_LAPACK -c src/scs.c -o out/obj/scs.o
In file included from include/scs.h:36,
from src/scs.c:28:
include/util.h:78:25: error: field 'tic' has incomplete type
78 | struct timespec tic;
| ^~~
include/util.h:79:25: error: field 'toc' has incomplete type
79 | struct timespec toc;
| ^~~
make: *** [Makefile:59: out/obj/scs.o] Error 1
```
Error was:
```
Building test runner...
gcc -g -Wall -Wwrite-strings -funroll-loops -Wstrict-prototypes -I. -Iinclude -fPIC -Ofast -DSVD_ACTIVATED=1 -DCTRLC=1 -DCOPYAMATRIX=1 -DLAPACK_LIB_FOUND -DUSE_LAPACK tests/c/test_runner_dir.c \
-o out/UNIT_TEST_RUNNER_DIR out/obj/test_dummy.o \
out/obj/test_broyden.o \
out/obj/test_superscs.o \
out/obj/test_utilities.o \
out/libscsdir.a -lm -lrt -lblas -llapack
/usr/bin/ld: out/obj/test_dummy.o:/tmp/superscs/include/unit_test_util.h:60: multiple definition of `number_of_assertions'; /tmp/ccXkP6mv.o:/tmp/superscs/include/unit_test_util.h:60: first defined here
/usr/bin/ld: out/obj/test_broyden.o:/tmp/superscs/include/unit_test_util.h:60: multiple definition of `number_of_assertions'; /tmp/ccXkP6mv.o:/tmp/superscs/include/unit_test_util.h:60: first defined here
/usr/bin/ld: out/obj/test_superscs.o:/tmp/superscs/include/unit_test_util.h:60: multiple definition of `number_of_assertions'; /tmp/ccXkP6mv.o:/tmp/superscs/include/unit_test_util.h:60: first defined here
/usr/bin/ld: out/obj/test_utilities.o:/tmp/superscs/include/unit_test_util.h:60: multiple definition of `number_of_assertions'; /tmp/ccXkP6mv.o:/tmp/superscs/include/unit_test_util.h:60: first defined here
/usr/bin/ld: out/libscsdir.a(unit_test_util.o):/tmp/superscs/include/unit_test_util.h:60: multiple definition of `number_of_assertions'; /tmp/ccXkP6mv.o:/tmp/superscs/include/unit_test_util.h:60: first defined here
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR moves the install procedure from Dockerfile to Makefile.
While here, it fixes a couple issues discussed in #29 and #34 to make things work on more modern system. As such, the base docker image can be updated from trusty to noble (14.04 to 24.04).
NB: as already discussed in #34, 3 unit tests are failing:
so the docker image only ensure tests are building fine for now.