Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Fixes in Intro #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evan-wang-13
Copy link

Type of PR: Typo Fixes
NetID: ew447

  • In the psuedocode for rule-based classification, I believe there is an extra comma after the elif statement. I understand this is pseudocode so exact correctness isn't necessary, but I think this syntax error could cause some confusion
  • In the discussion of executable course materials, I believe "an" is a typo. I think the sentence would make more sense if "an" was switched to "and". If the intent was to have "an" precede a noun phrase, a different grammatically correct sentence could be "We are going to embed executable code directly in the slides and use that to demonstrate algorithms"

@evan-wang-13 evan-wang-13 changed the title Typo Fixes in Intro (NetID: ew447) Typo Fixes in Intro Aug 26, 2024
Copy link

@shachideshpande shachideshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pseudocode comma is not customary to write after an elif statement. Conventionally, zif/elif statements are followed by a colon. Hence, this cannot be changed.

The other suggestion on 'an'->'and' can be incorporated.

@evan-wang-13
Copy link
Author

The pseudocode comma is not customary to write after an elif statement. Conventionally, zif/elif statements are followed by a colon. Hence, this cannot be changed.

The other suggestion on 'an'->'and' can be incorporated.

I agree that the comma is not customary to write after an elif statement. The change I am proposing is to remove the comma that is in the current pseudocode.

Screenshot 2024-11-04 162700

This snippet above shows what is on the current website. I am proposing to just have the colon, removing the extra comma.

@shachideshpande
Copy link

Thanks for the clarification. I read it the other way round accidentally. I am approving your PR.

Copy link

@shachideshpande shachideshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor typos were approved. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants