Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 typos #6

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

AdinaScheinfeld
Copy link

Replace "onens" with "ones" in comments in 2 different code cells.

@AdinaScheinfeld
Copy link
Author

Fixed more typos across lectures 1, 3, and 4.

@shachideshpande
Copy link

Hi, I can approve 15 grammatical typos suggested over a range of lectures. However, could you rectify the PR related to lecture 12? It creates a very large diff file and is hard to review.

Copy link

@shachideshpande shachideshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture 12 diff is huge. Can you change this?

I could approve 15 grammatical typos ranging over several lectures. However, the typos related to replacing ". to ." don't look right - we place punctuation after ending the double inverted commas. Could you revert those changes?

@@ -148,7 +148,7 @@
"\n",
"> Machine learning is a field of study that gives computers the ability to learn without being explicitly programmed.\n",
"\n",
"This definition is used in numerous courses and textbooks. At first, it might be hard to grasp what Samuel means by terms like \"learn\" and \"explicitly programmed\". Let's look at one final example to clarify this."
"This definition is used in numerous courses and textbooks. At first, it might be hard to grasp what Samuel means by terms like \"learn\" and \"explicitly programmed.\" Let's look at one final example to clarify this."
Copy link

@shachideshpande shachideshpande Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the punctuation after double inverted comma ending is more appropriate. Could you revert PR changes corresponding to this kind of typo throughout the documents?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the lecture notes, I found some periods and commas inside closing quotation marks and others outside. I switched the ones that were outside to bring them inside since in grammatically, in Standard American English, commas and periods are placed inside the closing quotation mark. Regardless of whether the commas and periods are inside or outside the closing quotation marks though, this should be consistent across all of the lecture notes.

https://owl.purdue.edu/owl/general_writing/punctuation/punctuation/index.html#:~:text=Note%20that%20commas%20and%20periods,and%20semicolons%20are%20placed%20outside

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what happened with lecture 12, but I will try to fix it. Can you please approve the other changes meanwhile?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying the suggestions on quotations. Since I am used to British English, I did not realise this difference in American English.

Please do add a comment here when you modify lecture 12. At the moment, the diff is so huge that it is impossible to see what changed.

I will approve the other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants