Skip to content

Enable fp16 for linear backward #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kulinseth merged 1 commit into from
Nov 18, 2022
Merged

Enable fp16 for linear backward #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions aten/src/ATen/native/mps/operations/Linear.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ Tensor _mps_linear(

auto weight = (weight_arg.dim() == 1) ? weight_arg.view({1, weight_arg.size(0)}) : weight_arg;

TORCH_CHECK(input.scalar_type() == ScalarType::Double
|| input.scalar_type() == ScalarType::Float
|| input.scalar_type() == ScalarType::Half, "MPS device does not support linear for non-float inputs");
TORCH_CHECK(input.scalar_type() == ScalarType::Float ||
input.scalar_type() == ScalarType::Half, "MPS device does not support linear for non-float inputs");

const Tensor& bias = *(at::borrow_from_optional_tensor(bias_opt));
bool is_bias_defined = bias.defined();
Expand Down Expand Up @@ -145,8 +144,9 @@ Tensor _mps_linear_backward_input(
{
TORCH_CHECK(grad_output.is_mps(),
"mps_linear_backward: grad_output needs to be mps layout");
TORCH_CHECK(weight.device().is_mps() && weight.scalar_type() == kFloat,
"mps_linear_backward: weight needs to be a dense tensor");
TORCH_CHECK(weight.device().is_mps() &&
(weight.scalar_type() == kFloat || (weight.scalar_type() == kHalf)),
"mps_linear_backward: unsupported weights data type: ", weight.scalar_type());

TORCH_CHECK(grad_output.scalar_type() == ScalarType::Double
|| grad_output.scalar_type() == ScalarType::Float
Expand Down Expand Up @@ -228,9 +228,8 @@ Tensor _mps_linear_backward_input(
TORCH_CHECK(grad_output.is_mps() && input.is_mps(),
"_mps_linear_backward: grad_output and input needs to be mps layout");

TORCH_CHECK(grad_output.scalar_type() == ScalarType::Double
|| grad_output.scalar_type() == ScalarType::Float
|| grad_output.scalar_type() == ScalarType::Half, "MPS device does not support linear backward for non-float inputs");
TORCH_CHECK(grad_output.scalar_type() == ScalarType::Float ||
grad_output.scalar_type() == ScalarType::Half, "MPS device does not support linear backward for non-float inputs");

struct CachedGraph : public MPSCachedGraph
{
Expand Down