Skip to content

Fix the crash in nan_to_num() with Float16 data type #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
razarmehr merged 1 commit into from
Jan 9, 2023
Merged

Fix the crash in nan_to_num() with Float16 data type #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions aten/src/ATen/native/mps/operations/TensorCompare.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,16 @@ Tensor where_mps(const Tensor& condition,
MPSGraphTensor* subZeroTensor = [mpsGraph lessThanWithPrimaryTensor: nanFreeTensor
secondaryTensor: [mpsGraph constantWithScalar: 0.0 dataType: self_dtype]
name: nil];
// the cast is a workaround for the issue #103149520 (crash when bool and fp16 passed to binary ops)
MPSGraphTensor* isNegInfTensor = [mpsGraph logicalANDWithPrimaryTensor: [mpsGraph castTensor: subZeroTensor toType: self_dtype name: @"castTensor"]
secondaryTensor: [mpsGraph isInfiniteWithTensor: nanFreeTensor name:nil]
MPSGraphTensor* isInfTensor = [mpsGraph isInfiniteWithTensor: nanFreeTensor name:nil];
// workaround for Monterey; On Ventura the output of lessThan() is always Boolean
if (subZeroTensor.dataType != MPSDataTypeBool) {
subZeroTensor = castMPSTensor(mpsGraph, subZeroTensor, kBool);
}
if (isInfTensor.dataType != MPSDataTypeBool) {
isInfTensor = castMPSTensor(mpsGraph, isInfTensor, kBool);
}
MPSGraphTensor* isNegInfTensor = [mpsGraph logicalANDWithPrimaryTensor: subZeroTensor
secondaryTensor: isInfTensor
name: nil];
MPSGraphTensor* negInfFreeTensor = [mpsGraph selectWithPredicateTensor: isNegInfTensor
truePredicateTensor: newCachedGraph->negInfReplacementTensor
Expand Down