Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use low precision for FP16 for divtrunc_rounding #263

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Use low precision for FP16 for divtrunc_rounding #263

merged 1 commit into from
Jan 27, 2023

Conversation

razarmehr
Copy link

  • remove interpolate from blocklist since it works
  • move interpolate_area to unimplemented list

@razarmehr
Use low precision for FP16 for divtrunc_rounding
2f9332c 
- remove interpolate from blocklist since it works
- move interpolate_area to unimplemented list
@razarmehr razarmehr merged commit d86a428 into master Jan 27, 2023
@razarmehr razarmehr deleted the razarmehr/divtrunc_fp16 branch January 27, 2023 17:07
kulinseth pushed a commit that referenced this pull request Feb 6, 2023
@razarmehr @kulinseth
Use low precision for FP16 for divtrunc_rounding (#263)
b96d593 
- remove interpolate from blocklist since it works
- move interpolate_area to unimplemented list
razarmehr added a commit that referenced this pull request Feb 10, 2023
@razarmehr
fix huberloss for float16 (#185)
111653c 
Add rtol/atol to the assertEqual() in gradient results check (#213)

Also create a list of ops that would be allowed to differ up to values defined by rtol/atol with FP16

Use low precision for FP16 for divtrunc_rounding (#263)

- remove interpolate from blocklist since it works
- move interpolate_area to unimplemented list

Fix FP16 precision issues for Grad tests (#281)

- This patch moves several Grad tests related to FP16 precision from block list to
FP16_LOW_PRECISION_LIST which should produce correct output.
@razarmehr razarmehr added Upstreamed Change has been upstreamed to PyTorch master RA: In Progress Ramin's PRs in progress labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@skotapati skotapati Awaiting requested review from skotapati

@Ronian526 Ronian526 Awaiting requested review from Ronian526

@DenisVieriu97 DenisVieriu97 Awaiting requested review from DenisVieriu97

Assignees
No one assigned
Labels
RA: In Progress Ramin's PRs in progress Upstreamed Change has been upstreamed to PyTorch master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razarmehr @kulinseth