Revert "Revert "Added zero check to inverse op, resolving crash seen … #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotapati
requested review from
DenisVieriu97,
Ronian526,
razarmehr and
ssaladis
DenisVieriu97
force-pushed
the
dev/skotapati/linalg_inv_test
branch
from
8b9a84d to
d81081b
Compare
razarmehr
reviewed
Feb 1, 2023
| MPSStream* stream = getCurrentMPSStream(); | ||
| info.zero_(); | ||
|
|
||
| if (A.numel() == 0) { |
There was a problem hiding this comment.
Can you move this code along with info.zero_() to the beginning of this function? Because if A.numel() == 0 , then the A.to("cpu") in the line 17 may cause problems:
at::linalg_inv_ex_out(cpu_result, cpu_info, A.to("cpu"));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in inverse & matrix_pow tests (#236)""
This reverts commit d88dc8b.
Segfaults seen during testing may have been device-specific. Creating PR to test using CI
Fixes #ISSUE_NUMBER