Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to fail all tests or exit jest when there are TSC errors? #250

Closed
masters3d opened this issue Jun 17, 2017 · 4 comments
Closed

How to fail all tests or exit jest when there are TSC errors? #250

masters3d opened this issue Jun 17, 2017 · 4 comments

Comments

@masters3d
Copy link
Contributor

masters3d commented Jun 17, 2017 •
edited
Loading

  • Issue

How do I fail the jest's tests when there are TSC errors?

  • Expected behavior

Tests failing if TSC gives errors

  • Link to a minimal repo that reproduces this issue

exercism/typescript#39 (comment)
@masters3d
Copy link
Contributor Author

masters3d commented Jun 17, 2017 •
edited
Loading

related: #219

In this sample repo: https://github.com/masters3d/xts-jest-hello-world
all tests pass but there are compiler errors.

@masters3d masters3d changed the title How do I fail the linter when there are TSC errors? How do I fail the all tests or jest when there are TSC errors? Jun 17, 2017
@masters3d masters3d changed the title How do I fail the all tests or jest when there are TSC errors? How to fail all tests or exit jest when there are TSC errors? Jun 17, 2017
@masters3d masters3d mentioned this issue Jun 17, 2017
Closed
@masters3d
Copy link
Contributor Author

related: #79

Seems to be a limitation on the compiler to emit errors
microsoft/TypeScript#4864

We could get diagnostics but then how does Jest display those. Tricky.
https://github.com/Microsoft/TypeScript/blob/master/src/compiler/types.ts#L2441

@masters3d
Copy link
Contributor Author

We are just going to use tsc --noEmit -p . && jest --no-cache

masters3d added a commit to masters3d/ts-jest that referenced this issue Jun 17, 2017
@masters3d
added known limitation
f1f0d49 
kulshekhar#250
@masters3d masters3d mentioned this issue Jun 17, 2017
Merged
@AlexGalays
Copy link

It was so surprising to discover ts-jest doesn't check for compilation errors ! This is especially bad in watch mode.

@hjfreyer hjfreyer mentioned this issue Feb 17, 2018
Closed
@mshustov mshustov mentioned this issue Feb 21, 2019
Closed
8 tasks
@andreialecu andreialecu mentioned this issue May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexGalays @masters3d