-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always do type check for all transformed files #1450
Conversation
Pull Request Test Coverage Report for Build 4189
💛 - Coveralls |
Will it still respect the For me, after updating to this version, I see the increased memory heap consumption (as if it was not using jest cache). Basically, with |
yes, this PR still respect |
Got it. Then my observations are probably caused by something else. Will keep an eye on the new version and report if I find anything else suspicious. Thanks for the great work BTW! |
watch mode fix will have to wait :) this PR only fixed the issue for non watch mode |
@kirillgroshkov besides the memory part, how do you see the speed of no cache in 25.3.0 comparing to 25.2.1 ? |
The speed, in terms of how many seconds it takes to complete all tests is more or less identical, so, no change between 25.2.1 and 25.3.0 |
thanks :) i'm glad to hear that. |
closes #1390
Previously we always do type checking while compiling codes. However, when a file is cached and the next time when running tests, our compiling logic won't be invoked when the file content (which is provided by
jest
as input forgetCacheKey
) is the same as cached content therefore the unchanged file won't be type checking.So the change is moving the part of type checking to the entry point
getCacheKey
whichjest
uses to determine whether a file should be recompiled or simply get cached content.