Troubleshoting section #1463
Merged
Troubleshoting section #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4253
💛 - Coveralls |
ahnpnl
reviewed
Mar 29, 2020
ahnpnl
reviewed
Mar 29, 2020
README.md
Outdated
| | **Installing** | `npm i -D ts-jest @types/jest` | `yarn add --dev ts-jest @types/jest` | | ||
| | **Creating config** | `npx ts-jest config:init` | `yarn ts-jest config:init` | | ||
| | **Running tests** | `npm t` or `npx jest` | `yarn test` or `yarn jest` | | ||
| | | using npm | using yarn | |
There was a problem hiding this comment.
Auto-formatted also.
ahnpnl
reviewed
Mar 29, 2020
README.md
Outdated
| * [TypeScript](https://www.typescriptlang.org/) - JavaScript that scales | ||
| * [Jest](https://jestjs.io/) - Delightful JavaScript Testing | ||
| * [`ts-jest`](https://kulshekhar.github.io/ts-jest) - Jest processor for TypeScript _(yes, `ts-jest` uses itself for its tests)_ | ||
| - [TypeScript](https://www.typescriptlang.org/) - JavaScript that scales |
There was a problem hiding this comment.
Auto-formatted also.
ahnpnl
reviewed
Mar 29, 2020
README.md
Outdated
| * **Gustav Wengel** - [GeeWee](https://github.com/GeeWee) | ||
| * **Ahn** - [ahnpnl](https://github.com/ahnpnl) | ||
| * **Huafu Gandon** - [huafu](https://github.com/huafu) | ||
| - **Kulshekhar Kabra** - [kulshekhar](https://github.com/kulshekhar) |
There was a problem hiding this comment.
Auto-formatted also.
ahnpnl
reviewed
Mar 29, 2020
TROUBLESHOOTING.md
Outdated
| } | ||
| ``` | ||
|
|
||
| - Check if module name is properly mapped and can be referenced by jest. If not add this on your existing jest configuration. |
There was a problem hiding this comment.
Perhaps we can change the text to Check if module name is properly mapped and can be referenced by jest. If not, you can define moduleNameMapper for your jest configuration.
There was a problem hiding this comment.
Ok I will change this line.
ahnpnl
reviewed
Mar 29, 2020
TROUBLESHOOTING.md
Outdated
| module.exports = { | ||
| ... | ||
| moduleNameMapper: { | ||
| "^.*shared/(.*)": "<rootDir>/src/shared/$1", |
There was a problem hiding this comment.
Can we use placeholder example here, something like "<import-path>": "<rootDir>/<real-physical-path>"
ahnpnl
reviewed
Mar 29, 2020
TROUBLESHOOTING.md
Outdated
| @@ -0,0 +1,43 @@ | |||
| # Troubleshooting | |||
|
|
|||
| This serves as a troubleshooting guide for any ts-jest related issues. | |||
There was a problem hiding this comment.
Ok I will remove this line.
|
Hi @mackignacio , would you please change your PR to only contain the new |
|
@ahnpnl I already applied the changes on the reviews. |
kulshekhar
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Troubleshootingsection in README.md file