Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add GitHub PR, issue templates #1487

Merged
merged 5 commits into from
Apr 2, 2020
Merged

chore: add GitHub PR, issue templates #1487

merged 5 commits into from
Apr 2, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 2, 2020

  • Add GitHub templates for PRs, issues

  • I also removed some diagnostics warning e2e tests since it's not so necessary to repeat the same as what we have for the case throw so we can improve the waiting time of our CI

@ahnpnl ahnpnl requested a review from kulshekhar April 2, 2020 12:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4308

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.784%
Totals Coverage Status
Change from base Build 4307: 0.0%
Covered Lines: 1143
Relevant Lines: 1179
💛 - Coveralls

@kulshekhar
Copy link
Owner

This looks great!

@ahnpnl ahnpnl merged commit c1dc228 into kulshekhar:master Apr 2, 2020
@ahnpnl ahnpnl mentioned this pull request Apr 2, 2020
Merged
@ahnpnl ahnpnl deleted the github-template branch April 3, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahnpnl @coveralls @kulshekhar