Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge support jest 26 #1602

Merged
merged 2 commits into from
May 6, 2020
Merged

Merge support jest 26 #1602

merged 2 commits into from
May 6, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented May 6, 2020

Summary

Merge changes to support jest 26

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner May 6, 2020 08:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4700

  • 23 of 24 (95.83%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.865%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/config/config-set.ts 9 10 90.0%
Totals Coverage Status
Change from base Build 4697: 0.0%
Covered Lines: 1067
Relevant Lines: 1103
💛 - Coveralls

@ahnpnl ahnpnl merged commit 23b7741 into master May 6, 2020
@ahnpnl ahnpnl deleted the next branch May 6, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahnpnl @coveralls @kulshekhar @murbanowicz