Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let sourcemaps be cached #292

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Let sourcemaps be cached #292

merged 1 commit into from
Aug 6, 2017

Conversation

kulshekhar
Copy link
Owner

This change allows source-map-support to use the default value for emptyCacheBetweenOperations (false) to improve the performance of ts-jest.

Thanks to @hermanbanken for pointing out this issue in #259

@GeeWee
Copy link
Collaborator

GeeWee commented Aug 6, 2017

Do we need to test jest multiple times in sequence to ensure this doesn't break e.g. --watch?

@kulshekhar
Copy link
Owner Author

kulshekhar commented Aug 6, 2017

Do we need to test jest multiple times in sequence to ensure this doesn't break e.g. --watch?

Sounds like a good idea. I'm not yet sure how to automate that though

Edit: A simple test showed this worked (displayed changed line numbers) with --watch

Edit 2: It looks like we're already testing this 😄

@GeeWee
Copy link
Collaborator

GeeWee commented Aug 6, 2017

I'm not sure about that either.
Just to be clear - did you pull this branch into a regular project and test it, or how did you test it?

@kulshekhar
Copy link
Owner Author

I'm not sure about that either.

I just updated my comment above. We're already testing this.

Just to be clear - did you pull this branch into a regular project and test it, or how did you test it?

I used the project linked from #259 to test this by changing the file in the ts-jest source in node_modules

@GeeWee
Copy link
Collaborator

GeeWee commented Aug 6, 2017

Damn, past us are smart people..!
Let's merge this baby in.

@kulshekhar kulshekhar merged commit 2671d31 into master Aug 6, 2017
@kulshekhar kulshekhar deleted the cache-sourcemaps branch August 6, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants