Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): remove onNodeVersions function #4253

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jan 19, 2024

Summary

Since we support only Node 16+, we can safely remove this function

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

Since we support only Node 16+, we can safely remove this function
@ahnpnl ahnpnl force-pushed the infra/improve-e2e branch from aaea2d1 to 809fcff Compare January 19, 2024 10:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7582551189

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 96.015%

Totals Coverage Status
Change from base Build 7582518249: -0.02%
Covered Lines: 4053
Relevant Lines: 4152

💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review January 19, 2024 10:34
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner January 19, 2024 10:34
@ahnpnl ahnpnl requested review from kulshekhar and removed request for kulshekhar January 19, 2024 10:38
@ahnpnl ahnpnl merged commit 2d16f4a into kulshekhar:main Jan 19, 2024
17 checks passed
@ahnpnl ahnpnl deleted the infra/improve-e2e branch January 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants