Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): fallback to NodeJS module resolution for ts 4.8 #4500

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Aug 7, 2024

Summary

Fixes #4499

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner August 7, 2024 11:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10283454698

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix/module-resolution-undefined at 95.264%

Totals Coverage Status
Change from base Build 10235958747: 95.3%
Covered Lines: 4759
Relevant Lines: 4937

💛 - Coveralls

@ahnpnl ahnpnl merged commit b7d3409 into main Aug 7, 2024
17 checks passed
@ahnpnl ahnpnl deleted the fix/module-resolution-undefined branch August 7, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Undefined moduleResolution
3 participants