Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape dot for several transform regex constants #4698

Merged
merged 4 commits into from
Feb 22, 2025
Merged

fix: escape dot for several transform regex constants #4698

merged 4 commits into from
Feb 22, 2025

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Feb 22, 2025

Summary

Fixes #4579

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13472408803

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.265%
Totals Coverage Status
Change from base Build 13416203435: 0.0%
Covered Lines: 4759
Relevant Lines: 4937
💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review February 22, 2025 11:35
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner February 22, 2025 11:35
@ahnpnl ahnpnl merged commit 36e50e4 into main Feb 22, 2025
17 checks passed
@ahnpnl ahnpnl deleted the fix/transform-regex branch February 22, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Default transform regex does not escape dot properly
3 participants
@ahnpnl @coveralls @kulshekhar