Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): ignore > Changelog if in comments and use prTitle instead of commit #35

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Nov 3, 2023

2 minor issues I discovered while massaging the changelog for 2.5.0

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner November 3, 2023 16:46
@lahabana lahabana requested review from Automaat, bartsmykla, michaelbeaumont, slonka and a team and removed request for a team November 3, 2023 16:46
@lahabana lahabana changed the title ignore > Changelog if in comments and use prTitle instead of commit fix: ignore > Changelog if in comments and use prTitle instead of commit Nov 3, 2023
Copy link

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, PR change is good

@lahabana lahabana changed the title fix: ignore > Changelog if in comments and use prTitle instead of commit fix(changelog): ignore > Changelog if in comments and use prTitle instead of commit Nov 3, 2023
@lahabana lahabana merged commit 80150a0 into main Nov 3, 2023
8 of 10 checks passed
@lahabana lahabana deleted the fixChangelogSkip branch November 3, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants