fix(openapi): clean up after resolving schema name #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka
requested review from
bartsmykla,
lobkovilya and
lahabana
and removed request for
a team
lukidzi
approved these changes
Jan 14, 2025
slonka
added a commit
to kumahq/kuma
that referenced
this pull request
Jan 16, 2025
## Motivation Because there was a bug in previous one that polluted the top level of the doc. ## Implementation information All in kumahq/ci-tools#60 ## Supporting documentation Just version bump Signed-off-by: slonka <slonka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise we end up with https://github.com/kumahq/kuma/blob/master/docs/generated/openapi.yaml#L6 in a top level
run this locally and got this:
so I'm assuming this works, although there are no tests in this repo
Did you sign your commit? Instructions yes
Have you read Contributing guidelines? yes