chore: prevents unwanted click events firing

Signed-off-by: John Cowen <john.cowen@konghq.com>
kumahq · Oct 9, 2024 · 2264a02 · 2264a02
1 parent d3a8553
commit 2264a02
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/app/application/components/app-collection/AppCollection.vue b/src/app/application/components/app-collection/AppCollection.vue
@@ -119,7 +119,6 @@ function getRowAttributes(row: Row): Record<string, string> {
 
   return attributes
 }
-
 const click = (e: MouseEvent) => {
   const $tr = (e.target as HTMLElement).closest('tr')
   if ($tr) {
@@ -129,7 +128,8 @@ const click = (e: MouseEvent) => {
       }
       return prev
     }, null)
-    if ($a !== null && $a.closest('tr, li') === $tr) {
+    if ((window.getSelection()?.isCollapsed ?? true) && $a !== null && $a.closest('tr, li') === $tr) {
+      e.preventDefault()
       $a.click()
     }
   }

diff --git a/src/app/common/SummaryView.vue b/src/app/common/SummaryView.vue
@@ -32,7 +32,7 @@ onClickOutside(
   slideOutRef,
   useThrottleFn((event: PointerEvent) => {
     const $el = event.target as HTMLElement
-    if (event.isTrusted && $el.nodeName.toLowerCase() !== 'a') {
+    if ((window.getSelection()?.isCollapsed ?? true) && !event.defaultPrevented && event.isTrusted && $el.nodeName.toLowerCase() !== 'a') {
       emit('close')
     }
   }, 1, true, false),