New dataplane tag UI #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tag and its value. this change accounts for gateway mode dataplanes as well.
|
Please add a border and the background of the box on the right (where the value is located) becomes white. Also remove the semicolon from the tag name. Similar to:
|
added 2 commits
February 3, 2020 10:54
…ble use in the tags list on data tables. style revisions for the tags.
…nt them from stacking too close to one another when there are multiple tags on smaller screens.
|
@subnetmarco I've revised the tag styles to match your example. I also increased spacing for when there are multiple tags so that they don't stack awkwardly. Let me know what you think. |
|
This works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives the tags on a dataplane a more user-friendly experience and will include color-coding based on the tag type (env, service, version, etc). The revision also makes sure to account for dataplanes that are in gateway mode.